Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty state events show a blank box in the timeline #2102

Closed
frebib opened this issue Dec 24, 2023 · 0 comments · Fixed by #2112
Closed

Empty state events show a blank box in the timeline #2102

frebib opened this issue Dec 24, 2023 · 0 comments · Fixed by #2112
Assignees
@bmarty
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users

Comments

@frebib
Copy link
Contributor

frebib commented Dec 24, 2023

In EXA it shows an empty box (you can see the highlight in this screenshot)
Screenshot_20231224-212804~2.png

In old Element it handles this case explicitly
Screenshot_20231224-092750.png

The model even has change: Some(None) so Rust knows it's a no-op state event.
@bmarty bmarty added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Timeline S-Tolerable Low/no impact on users labels Dec 26, 2023
@bmarty bmarty self-assigned this Dec 26, 2023
bmarty added a commit that referenced this issue Dec 26, 2023
@bmarty
Handle MembershipChange.NONE rendering in the timeline #2102
62d1eed 
And avoid `else` in the when statement.
@bmarty bmarty mentioned this issue Dec 26, 2023
Merged
14 tasks
bmarty added a commit that referenced this issue Dec 26, 2023
@bmarty
Handle MembershipChange.NONE rendering in the timeline #2102
ac7d46c 
And avoid `else` in the when statement.
bmarty added a commit that referenced this issue Dec 28, 2023
@bmarty
Merge pull request #2112 from element-hq/feature/bma/renderStateWitho…
aad7e83 
…utChanges

Handle `MembershipChange.NONE` rendering in the timeline #2102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle MembershipChange.NONE rendering in the timeline #2102 element-hq/element-x-android
2 participants
@frebib @bmarty