Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload app id and clean version to bug reports #2829

Merged
merged 3 commits into from
May 10, 2024

Conversation

jmartinesp
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Add app_id property to bug reports so we can know if it's a debug, nightly or release version.
  • Send a Version property with the plain version of the app (i.e. 0.4.11, without any suffix).

Motivation and context

It should help differentiating versions in rageshakes, up to these changes only the user agent had any versioning info.

Tests

Bug report correctly uploaded to https://github.com/element-hq/element-x-android-rageshakes/issues/1995.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner May 10, 2024 09:58
@jmartinesp jmartinesp requested review from bmarty and removed request for a team May 10, 2024 09:58
Copy link
Contributor

github-actions bot commented May 10, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wJCgAE

Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.95%. Comparing base (b95df7e) to head (48f624d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2829   +/-   ##
========================================
  Coverage    73.95%   73.95%           
========================================
  Files         1530     1530           
  Lines        36539    36541    +2     
  Branches      7074     7074           
========================================
+ Hits         27023    27025    +2     
  Misses        5811     5811           
  Partials      3705     3705           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp merged commit 1f4b2d3 into develop May 10, 2024
16 checks passed
@jmartinesp jmartinesp deleted the misc/jme/add-version-property-to-bug-reports branch May 10, 2024 10:15
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The labels were not sufficient?

image

@jmartinesp
Copy link
Contributor Author

I think it made some automation harder because you had 0.4.11 and then0.4.11-nightly. @kegsay probably has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants