Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload app id and clean version to bug reports #2829

Merged
merged 3 commits into from
May 10, 2024
Merged

Upload app id and clean version to bug reports #2829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c29587c
Upload app id and clean version to bug reports
jmartinesp May 10, 2024
d0929ed
Add changelog
jmartinesp May 10, 2024
48f624d
Fix tests
jmartinesp May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/2829.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add missing `app_id` and `Version` properties to bug reports.
3 changes: 3 additions & 0 deletions ...src/main/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ class DefaultBugReporter @Inject constructor(
.addFormDataPart("sdk_sha", sdkMetadata.sdkGitSha)
.addFormDataPart("local_time", LocalDateTime.now().format(DateTimeFormatter.ISO_DATE_TIME))
.addFormDataPart("utc_time", LocalDateTime.ofInstant(Instant.now(), ZoneOffset.UTC).format(DateTimeFormatter.ISO_DATE_TIME))
.addFormDataPart("app_id", buildMeta.applicationId)
// Nightly versions have a custom version name suffix that we should remove for the bug report
.addFormDataPart("Version", buildMeta.versionName.replace("-nightly", ""))
currentTracingFilter?.let {
builder.addFormDataPart("tracing_filter", it)
}
Expand Down
2 changes: 1 addition & 1 deletion ...test/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporterTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,6 @@ class DefaultBugReporterTest {
}

companion object {
private const val EXPECTED_NUMBER_OF_PROGRESS_VALUE = 15
private const val EXPECTED_NUMBER_OF_PROGRESS_VALUE = 17
}
}
Loading