-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encrypted db #2244
Encrypted db #2244
Conversation
...main/kotlin/io/element/android/libraries/matrix/impl/auth/RustMatrixAuthenticationService.kt
Outdated
Show resolved
Hide resolved
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
dd80083
to
dfe68c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2244 +/- ##
===========================================
+ Coverage 69.95% 69.99% +0.04%
===========================================
Files 1335 1335
Lines 32656 32643 -13
Branches 6791 6789 -2
===========================================
+ Hits 22844 22848 +4
+ Misses 6535 6518 -17
Partials 3277 3277 ☔ View full report in Codecov by Sentry. |
dfe68c1
to
538391d
Compare
The passphrase is stored in the SessionData, so that a Session created by Element Android can be restored. Existing sessions will have a null passphrase and will continue to work. New session will use a passphrase, only on Nightly and Debug build for now.
538391d
to
3a91f83
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Type of change
Content
Ensure the application is providing a passphrase, for the SDK to encrypt the stored data.
The passphrase is stored in the
SessionData
, so that a Session created by Element Android can be restored (still need to create a PR on Element Android to store the passphrase to the correct location)Enabled on Debug and Nightly builds for now.
Motivation and context
Closes #2219
Part of #86
Screenshots / GIFs
Tests
To check if the database is encrypted, you need access to the file storage of the device.
Database are stored at:
Tested devices
Checklist