Fix some todo #2360
Merged
Fix some todo #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was used at the beginning of the project, but is not useful anymore.
…, not only for the error dialog.
bmarty
commented
Feb 7, 2024
| class SessionDirectoryNameProvider { | ||
| // Rust sanitises the user ID replacing invalid characters with an _ | ||
| fun provides(sessionId: SessionId): String { | ||
| return sessionId.value.replace(":", "_") |
There was a problem hiding this comment.
Once matrix-org/matrix-rust-sdk#3098 will be done, we may iterate on this.
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup on the project, may be reviewed commit per commit.