Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FilterHiddenStateEventsProcessor #2368

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

jmartinesp
Copy link
Contributor

@jmartinesp jmartinesp commented Feb 8, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Remove FilterHiddenStateEventsProcessor.
  • Remove isVisibleInTimeline() method in EventContent and OtherState.

Motivation and context

The same process is already done by the Rust SDK, so it's now redundant.

Tests

  • In a room, change something that would send one of the hidden state events, such as the power levels for different actions.
  • Open the room in the EX app, check that none of those events appear in the timeline.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

The same process is already done by the Rust SDK, so it's now redundant.
@jmartinesp jmartinesp requested a review from a team as a code owner February 8, 2024 12:40
@jmartinesp jmartinesp requested review from bmarty and removed request for a team February 8, 2024 12:40
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Feb 8, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/81bVHV

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@jmartinesp jmartinesp merged commit 89bcd37 into develop Feb 8, 2024
14 checks passed
@jmartinesp jmartinesp deleted the misc/jme/remove-hidden-event-type-filter branch February 8, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants