Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add room moderation feature flag #2495

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jmartinesp
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Added room moderation feature flag.

Motivation and context

I completely forgot to add this before merging #2423 😅 .

Tests

  • Open the developer settings, make sure 'room moderation' is disabled.
  • Go to a room where you're an admin. The 'roles and permissions' item shouldn't appear.
  • Now enable the feature flag.
  • Go back to the room: the item should be there.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner March 6, 2024 07:52
@jmartinesp jmartinesp requested review from bmarty and ganfra and removed request for a team and bmarty March 6, 2024 07:52
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Mar 6, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Qn6dP1

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.94%. Comparing base (b9d902e) to head (442dfbc).

Files Patch % Lines
.../features/roomdetails/impl/RoomDetailsPresenter.kt 50.00% 0 Missing and 1 partial ⚠️
...ries/featureflag/impl/StaticFeatureFlagProvider.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2495   +/-   ##
========================================
  Coverage    72.94%   72.94%           
========================================
  Files         1387     1387           
  Lines        33176    33184    +8     
  Branches      6432     6432           
========================================
+ Hits         24200    24207    +7     
- Misses        5619     5620    +1     
  Partials      3357     3357           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp merged commit 97f2620 into develop Mar 6, 2024
16 checks passed
@jmartinesp jmartinesp deleted the misc/jme/add-room-moderation-feature-flag branch March 6, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants