Fix double back navigation in roles and permissions screen

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Change use of SideEffect for LaunchedEffect, which prevents the action from being called twice when recomposing.

Motivation and context

After saving changes in the 'edit admins' or 'edit moderators' screens, tapping the back navigation arrow went back twice.

Tests

• Go to a role where you're an admin, select 'roles and permissions' in its settings.
• Select the 'Moderators' item.
• Toggle the moderator role permissions in some user, save the changes.
• Tap on the back arrow icon in the top app bar. If it only goes back once, it's fixed.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gLfrZF

[bmarty]

LGTM, I propose an alternative fix, but your proposal is OK!

The screenshot test are not passing, did not check yet what is failing. EDIT: I guess updating the branch should fix it. I do it.

[bmarty]

Another possible fix is to use AsyncActionView:

        AsyncActionView(
            async = state.exitState,
            onSuccess = { updatedOnBackPressed() },
            confirmationDialog = {
                ConfirmationDialog(
                    title = stringResource(CommonStrings.dialog_unsaved_changes_title),
                    content = stringResource(CommonStrings.dialog_unsaved_changes_description_android),
                    onSubmitClicked = { state.eventSink(ChangeRolesEvent.Exit) },
                    onDismiss = { state.eventSink(ChangeRolesEvent.CancelExit) }
                )
            },
            onErrorDismiss = { /* Cannot happen */ },
        )

[jmartinesp]

Oh true, it's the perfect place to use it. Thanks!

Done in 3037b77

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.97%. Comparing base (410954e) to head (3037b77).
Report is 12 commits behind head on develop.

Files	Patch %	Lines
...rolesandpermissions/changeroles/ChangeRolesView.kt	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2506      +/-   ##
===========================================
- Coverage    72.97%   72.97%   -0.01%     
===========================================
  Files         1394     1394              
  Lines        33511    33512       +1     
  Branches      6493     6492       -1     
===========================================
  Hits         24455    24455              
- Misses        5671     5672       +1     
  Partials      3385     3385              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud