Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub page rendering #2512

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Fix GitHub page rendering #2512

merged 3 commits into from
Mar 8, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 8, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fix rendering of GitHub page (will have to be deployed again), and add a column for the dark version of the screenshots.

image

Note: will give a try to https://github.com/actions/deploy-pages later, now the current solution to deploy the pages is working.

Motivation and context

Fixes and improvement

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner March 8, 2024 11:14
@bmarty bmarty requested review from jmartinesp and removed request for a team March 8, 2024 11:14
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

github-actions bot commented Mar 8, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/rbFdGw

@bmarty bmarty merged commit f0616e7 into develop Mar 8, 2024
15 checks passed
@bmarty bmarty deleted the feature/bma/fixHtml branch March 8, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants