Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string import #2534

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Fix string import #2534

merged 3 commits into from
Mar 13, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 12, 2024

I have noticed some duplication of string when importing from Localazy (See #2533).

This PR update the config.json file to only import desired string in the :features:messages:impl module.

As a side effect, some unused strings are now imported to the main string module. These are duplicated strings which are not used on Android. We will have to do some cleanup later.

@bmarty bmarty requested a review from a team as a code owner March 12, 2024 15:34
@bmarty bmarty requested review from jmartinesp and removed request for a team March 12, 2024 15:34
@ElementBot
Copy link
Collaborator

ElementBot commented Mar 12, 2024

Warnings
⚠️

features/messages/impl/src/main/res/values-be/translations.xml#L45 - For locale "be" (Belarusian) the following quantity should also be defined: few (e.g. "з 2 кніг за 2 дні")

⚠️

features/messages/impl/src/main/res/values-cs/translations.xml#L16 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

features/messages/impl/src/main/res/values-cs/translations.xml#L45 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

features/messages/impl/src/main/res/values-cs/translations.xml#L50 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

features/messages/impl/src/main/res/values-sk/translations.xml#L16 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

features/messages/impl/src/main/res/values-sk/translations.xml#L45 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

features/messages/impl/src/main/res/values-sk/translations.xml#L50 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L4 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L22 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L151 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L173 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L4 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L22 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L150 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L172 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against 77fe8f0

"screen_room_reactions.*",
"screen_room_retry.*",
"screen_room_timeline.*",
"screen_room_typing.*"
Copy link
Member Author

@bmarty bmarty Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to rename some string keys on Localazy to have a common prefix like screen_room_timeline_, but this require to do some change in the codebase both on Android and iOS codebase.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(will do in #2535)

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/F89FW7

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.24%. Comparing base (ad17afe) to head (77fe8f0).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2534   +/-   ##
========================================
  Coverage    73.24%   73.24%           
========================================
  Files         1400     1400           
  Lines        33819    33819           
  Branches      6546     6546           
========================================
  Hits         24772    24772           
  Misses        5632     5632           
  Partials      3415     3415           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 357ed0a into develop Mar 13, 2024
17 checks passed
@bmarty bmarty deleted the feature/bma/fixStringImport branch March 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants