-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix string import #2534
Fix string import #2534
Conversation
…een_room_.*" was not filtering enough, and `excludeRegex` was not complete enough.
|
"screen_room_reactions.*", | ||
"screen_room_retry.*", | ||
"screen_room_timeline.*", | ||
"screen_room_typing.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be nice to rename some string keys on Localazy to have a common prefix like screen_room_timeline_
, but this require to do some change in the codebase both on Android and iOS codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(will do in #2535)
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2534 +/- ##
========================================
Coverage 73.24% 73.24%
========================================
Files 1400 1400
Lines 33819 33819
Branches 6546 6546
========================================
Hits 24772 24772
Misses 5632 5632
Partials 3415 3415 ☔ View full report in Codecov by Sentry. |
I have noticed some duplication of string when importing from Localazy (See #2533).
This PR update the
config.json
file to only import desired string in the:features:messages:impl
module.As a side effect, some unused strings are now imported to the main string module. These are duplicated strings which are not used on Android. We will have to do some cleanup later.