Test and verify coverage only on debug variant #2556
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2556 +/- ##
===========================================
- Coverage 73.18% 73.16% -0.02%
===========================================
Files 1407 1407
Lines 34062 34062
Branches 6609 6609
===========================================
- Hits 24927 24921 -6
- Misses 5685 5689 +4
- Partials 3450 3452 +2 ☔ View full report in Codecov by Sentry. |
|
I don't see a good way to keep the coverage, since the missing tests can only be run on release mode given our |
| - name: ⚙️ Run unit tests, debug and release | ||
| run: ./gradlew test $CI_GRADLE_ARG_PROPERTIES | ||
| - name: ⚙️ Run unit tests for debug variant | ||
| run: ./gradlew testDebugUnitTest $CI_GRADLE_ARG_PROPERTIES |
There was a problem hiding this comment.
I am wondering if ./gradlew testGplayDebugUnitTest would be enough.
There was a problem hiding this comment.
Probably. I kept it like that in case we add some fdroid only tests in the future. I'll change it and see if anything changes.
There was a problem hiding this comment.
Actually, that will only run :app:testGplayDebugUnitTest according to --dry-run, since the flavor only exists in that module.
| @@ -189,7 +188,7 @@ androidComponents { | |||
| val abiCode = abiVersionCodes[name] ?: 0 | |||
| // Assigns the new version code to output.versionCode, which changes the version code | |||
| // for only the output APK, not for the variant itself. | |||
| output.versionCode.set((output.versionCode.get() ?: 0) * 10 + abiCode) | |||
| output.versionCode.set((output.versionCode.orNull ?: 0) * 10 + abiCode) | |||
| @@ -215,26 +214,6 @@ knit { | |||
| } | |||
| } | |||
|
|
|||
| val ciBuildProperty = "ci-build" | |||
There was a problem hiding this comment.
The parameter ci-build is also used in nightlyReports.yml, I think it can be removed from this file too.
|
Type of change
Content
Only test and verify coverage on debug variant.
Motivation and context
Checklist