Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Konsist tests to quality checks #2558

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

jmartinesp
Copy link
Contributor

@jmartinesp jmartinesp commented Mar 15, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Add tests:konsist:testDebugUnitTest to runQualityChecks as a dependency.
  • Make Konsist tests be not up to date for every task with check (case-insensitive) in it, which includes the runQualityChecks one.

Motivation and context

The Konsist tests are more of a quality of code checks than actual tests.

This change should also help us avoid running them for every single test task, including Kover ones.

Checklist

This should also help us avoid running them for every single test task, including Kover.
Copy link
Contributor

github-actions bot commented Mar 15, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/yyRCCB

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.18%. Comparing base (694f551) to head (81193a7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2558   +/-   ##
========================================
  Coverage    73.18%   73.18%           
========================================
  Files         1407     1407           
  Lines        34062    34062           
  Branches      6609     6609           
========================================
  Hits         24927    24927           
  Misses        5685     5685           
  Partials      3450     3450           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp requested a review from bmarty March 15, 2024 12:35
@jmartinesp jmartinesp marked this pull request as ready for review March 15, 2024 12:36
@jmartinesp jmartinesp requested a review from a team as a code owner March 15, 2024 12:36
@jmartinesp
Copy link
Contributor Author

To verify the Konsist tests are passing, you can download the reports from the summary here.

@jmartinesp jmartinesp removed the request for review from a team March 15, 2024 12:36
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Konsist tests are more of a quality of code checks than actual tests.

true.

Thanks!

@jmartinesp jmartinesp merged commit 57e6db8 into develop Mar 15, 2024
16 checks passed
@jmartinesp jmartinesp deleted the misc/jme/move-konsist-to-quality-checks branch March 15, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants