Remove unnecessary Room.updateMembers() calls.

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Remove unnecessary Room.updateMembers() calls.

Some of them can be directly removed since we have a way to automatically get member info updates based on membership changes.

Others can be replaced by a simpler getUpdatedMember(userId) method. This might still do a full member sync, but it's quite unlikely, and even if it does it we won't have to map every fetched user before we can use the result.

Motivation and context

After testing the improved room member list and updateMembers() sometimes causing 45MB of data to be loaded for the Matrix HQ room, I want to reduce these calls as much as possible. It should also improve performance since we avoid unnecessary data mapping.

Tests

There should be no changes. I tested the following flows:

• In a DM, have the other user leave the room. Then tap on the message composer to re-invite them.
• Open the room details screen of a user, block and unblock them.
• Invite a new user to a room.
• Open the room member list.

As far as I could tell they all still worked as expected.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/utsQhi

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.14%. Comparing base (1e4300d) to head (4159160).
Report is 3 commits behind head on develop.

Files	Patch %	Lines
...droid/libraries/matrix/test/room/FakeMatrixRoom.kt	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2564      +/-   ##
===========================================
- Coverage    73.14%   73.14%   -0.01%     
===========================================
  Files         1408     1408              
  Lines        34103    34102       -1     
  Branches      6620     6620              
===========================================
- Hits         24945    24944       -1     
  Misses        5698     5698              
  Partials      3460     3460              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

LGTM at first sight. Thanks!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud