-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read user avatar from cache #2565
Conversation
…ster, and even if there is no network (#2488).
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The code looks good and the issue is fixed 👍 .
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2565 +/- ##
===========================================
- Coverage 73.14% 73.12% -0.02%
===========================================
Files 1408 1407 -1
Lines 34103 34092 -11
Branches 6620 6617 -3
===========================================
- Hits 24945 24931 -14
- Misses 5698 5703 +5
+ Partials 3460 3458 -2 ☔ View full report in Codecov by Sentry. |
a51855a should fix the coverage drop. |
Quality Gate passedIssues Measures |
Type of change
Content
Ensure the user avatar in the room list is rendered even if there is no network. The avatar will also be rendered faster in case of slow network, since it's now read from cache.
In this PR the user profile will be read from cache, previously 2 network requests was trigger on in received Push. This will speed up the display of the notification and reduce the network request.
Motivation and context
Fast UI
Closes #2488
Screenshots / GIFs
Tests
Previously the avatar was not rendered in this case.
Tested devices
Checklist