Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace leftover hardcoded string with the right text #2592

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

jmartinesp
Copy link
Contributor

@jmartinesp jmartinesp commented Mar 22, 2024

Our QA team™ found this earlier today.

@jmartinesp jmartinesp requested a review from a team as a code owner March 22, 2024 13:12
@jmartinesp jmartinesp requested review from bmarty and removed request for a team March 22, 2024 13:12
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/oAZUaF

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.20%. Comparing base (ab46fc1) to head (b89db6b).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2592   +/-   ##
========================================
  Coverage    73.20%   73.20%           
========================================
  Files         1413     1413           
  Lines        34296    34296           
  Branches      6670     6670           
========================================
  Hits         25105    25105           
  Misses        5717     5717           
  Partials      3474     3474           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I wish lint will check issues like this at some point...

@jmartinesp jmartinesp merged commit 4960621 into develop Mar 22, 2024
17 checks passed
@jmartinesp jmartinesp deleted the fix/jme/hardcoded-string-in-room-details branch March 22, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants