Move session verification to FTUE flow, make it mandatory

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

• Moves the session verification flow to be the first step of the FTUE flow.
• Makes it mandatory.
• Removes session verification banner.
• Implements new designs from Figma.
• Fixes bug with verification cancellation.

Motivation and context

Closes #2580.

Screenshots / GIFs

verification-in-ftue.webm

Tests

• Do a fresh log in.
• The FTUE flow should now start with the session verification. It shouldn't be skippable.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/CNTnxv

[codecov]

Codecov Report

Attention: Patch coverage is 84.66667% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 73.37%. Comparing base (f4076dc) to head (525eb67).
Report is 6 commits behind head on develop.

Files	Patch %	Lines
...atures/verifysession/impl/VerifySelfSessionView.kt	85.18%	3 Missing and 9 partials ⚠️
...erifysession/impl/VerifySelfSessionStateMachine.kt	88.46%	0 Missing and 3 partials ⚠️
...atures/preferences/impl/tasks/ClearCacheUseCase.kt	0.00%	2 Missing ⚠️
...securebackup/impl/DefaultSecureBackupEntryPoint.kt	0.00%	2 Missing ⚠️
...oid/features/ftue/impl/state/DefaultFtueService.kt	94.11%	0 Missing and 1 partial ⚠️
...impl/timeline/components/TimelineItemVirtualRow.kt	0.00%	1 Missing ⚠️
...s/verifysession/impl/VerifySelfSessionPresenter.kt	66.66%	0 Missing and 1 partial ⚠️
...rix/api/verification/SessionVerificationService.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2594      +/-   ##
===========================================
- Coverage    73.37%   73.37%   -0.01%     
===========================================
  Files         1459     1458       -1     
  Lines        35177    35151      -26     
  Branches      6752     6746       -6     
===========================================
- Hits         25812    25792      -20     
+ Misses        5851     5848       -3     
+ Partials      3514     3511       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ganfra]

Good work, I just have some remarks.

[ganfra]

Maybe better like this?

val isVerified by remember {
            verificationService.sessionVerifiedStatus.map { it == SessionVerifiedStatus.Verified }
        }.collectAsState(initial = false)
        LaunchedEffect(isVerified) {

[ganfra]

Maybe we should rename Root to RoomList

[ganfra]

It feels a bit strange to do that. I'd let the FtueState exposes a Loading state instead.
(maybe we should rename FtueState to be FtueService and have a proper FtueState because it's a bit misleading currently).

You could replace everything by something like this afterwards

        ftueFlow
            .onEach { ftueState ->
                when(ftueState){
                    FtueState.Loading -> Unit // don't do anything, Placeholder is the default node. If app is killed we don't want to loose our current navigation state.
                    is FtueState.Loaded -> {
                        if(ftueState.isCompleted){
                            backstack.safeRoot(NavTarget.RoomList)
                        } else {
                            backstack.safeRoot(NavTarget.Ftue)
                        }
                    }
                }
            }

[jmartinesp]

Thanks for the review! I believe ad4ffb2 should fix all those issues.

[ganfra]

Thanks for the changes, LGTM!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud