Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoomList filters : enable the feature for production build #2605

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ganfra
Copy link
Contributor

@ganfra ganfra commented Mar 26, 2024

Closes #2603

@ganfra ganfra marked this pull request as ready for review March 26, 2024 09:03
@ganfra ganfra requested a review from a team as a code owner March 26, 2024 09:03
@ganfra ganfra requested review from bmarty and removed request for a team March 26, 2024 09:03
@ganfra ganfra added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Mar 26, 2024
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Yd6j9z

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.19%. Comparing base (d3f2190) to head (e4aaf6a).
Report is 2 commits behind head on develop.

Files Patch % Lines
...ries/featureflag/impl/StaticFeatureFlagProvider.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2605   +/-   ##
========================================
  Coverage    73.19%   73.19%           
========================================
  Files         1413     1413           
  Lines        34286    34286           
  Branches      6669     6669           
========================================
  Hits         25096    25096           
  Misses        5716     5716           
  Partials      3474     3474           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 26, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 26, 2024
@ganfra ganfra merged commit f31b50a into develop Mar 26, 2024
21 of 22 checks passed
@ganfra ganfra deleted the feature/fga/enable_room_list_filters branch March 26, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Enable feature "RoomList Filters"
2 participants