Feature/fga/room directory #2620

ganfra · 2024-03-28T16:03:55Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Room directory search should disabled for release build.
Can be enabled in preferences in debug/nightly.

The feature is accessible from room list search.

More complex navigation will be handled by permalink feature (opening room preview before joining, knocking...).

Motivation and context

Closes #2578

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes have been tested on an Android device or Android emulator with API 23
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR

bmarty

LGTM, and tested OK. A few minor remarks

bmarty · 2024-03-28T17:24:56Z

features/roomdirectory/impl/build.gradle.kts

+ */
+
+// TODO: Remove once https://youtrack.jetbrains.com/issue/KTIJ-19369 is fixed
+@Suppress("DSL_SCOPE_VIOLATION")


You should update our template, this can be removed :)

bmarty · 2024-03-28T17:27:20Z

...rc/main/kotlin/io/element/android/features/roomdirectory/impl/root/RoomDirectoryPresenter.kt

+            // debounce search query
+            delay(300)
+            // cancel load more right away
+            loadingMore = false


right away, so maybe before the delay?

bmarty · 2024-03-28T17:38:11Z

...featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlags.kt

+    RoomDirectorySearch(
+        key = "feature.roomdirectorysearch",
+        title = "Room directory search",
+        description = "Allow user to search for public rooms in his homeserver",


Suggested change

description = "Allow user to search for public rooms in his homeserver",

description = "Allow user to search for public rooms in their homeserver",

bmarty · 2024-03-28T17:39:04Z

...api/src/main/kotlin/io/element/android/libraries/matrix/api/roomdirectory/RoomDescription.kt

+    val avatarUrl: String?,
+    val joinRule: JoinRule,
+    val isWorldReadable: Boolean,
+    val joinedMembers: Long


Maybe rename to numberOfMembers?

bmarty · 2024-03-28T17:43:04Z

...ain/kotlin/io/element/android/features/roomdirectory/impl/root/RoomDirectoryStateProvider.kt

+        RoomDescription(
+            roomId = RoomId("!exa:matrix.org"),
+            name = "Element X Android",
+            description = "Element X is a secure, private and decentralized messenger.",


Element X is not really decentralized :)

ElementBot · 2024-03-29T10:39:58Z

	Warnings
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L4 - For locale "cs" (Czech) the following quantity should also be defined: `many` (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L22 - For locale "cs" (Czech) the following quantity should also be defined: `many` (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L152 - For locale "cs" (Czech) the following quantity should also be defined: `many` (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L174 - For locale "cs" (Czech) the following quantity should also be defined: `many` (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L4 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L22 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L151 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L173 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against 8325583

github-actions · 2024-03-29T10:50:44Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/26nfhG

sonarcloud · 2024-03-29T15:26:54Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-03-29T15:40:39Z

Codecov Report

Attention: Patch coverage is 83.14607% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 73.31%. Comparing base (bd5c6ea) to head (8325583).
Report is 5 commits behind head on develop.

Files	Patch %	Lines
...tures/roomdirectory/impl/root/RoomDirectoryView.kt	76.86%	7 Missing and 24 partials ⚠️
...omdirectory/impl/DefaultRoomDirectoryEntryPoint.kt	0.00%	6 Missing ⚠️
.../roomdirectory/impl/root/RoomDirectoryPresenter.kt	85.71%	3 Missing and 3 partials ⚠️
...s/roomdirectory/impl/root/model/RoomDescription.kt	68.42%	1 Missing and 5 partials ⚠️
...id/features/roomdirectory/impl/root/di/JoinRoom.kt	0.00%	3 Missing ⚠️
...eatures/roomlist/impl/search/RoomListSearchView.kt	78.57%	1 Missing and 2 partials ⚠️
.../android/libraries/matrix/test/FakeMatrixClient.kt	40.00%	3 Missing ⚠️
...res/roomdirectory/impl/root/RoomDirectoryEvents.kt	75.00%	1 Missing ⚠️
...ries/featureflag/impl/StaticFeatureFlagProvider.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2620      +/-   ##
===========================================
+ Coverage    73.20%   73.31%   +0.10%     
===========================================
  Files         1413     1428      +15     
  Lines        34306    34661     +355     
  Branches      6670     6718      +48     
===========================================
+ Hits         25115    25412     +297     
- Misses        5717     5743      +26     
- Partials      3474     3506      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ganfra added 15 commits March 20, 2024 12:59

Room Directory Search : setup the feature

6e8d0de

Room directory search : branch entry point

a8028ba

Room directory search : start implementing ui with fake data

b0894fc

Room directory : change names and adapt ui

fa7a889

Merge branch 'develop' into feature/fga/room_directory

3eae08b

Room Directory : start exposing the matrix apis

01e6b46

RoomDirectory : continue implementing the search

4c5ae6a

Room directory : fix pagination and add empty state.

e4c7118

Room directory : start branching join event

0c96769

Room directory : implement simple join room

90b2a65

RoomList Search : do not persist isActive when leaving composition

153e88d

RoomDirectory : continue improving interactions

b900818

RoomDirectory : branch feature flag

d632e21

Merge branch 'develop' into feature/fga/room_directory

37d645d

Room directory : add tests and cleanup

3f1f764

ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Mar 28, 2024

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Mar 28, 2024

ElementBot and others added 2 commits March 28, 2024 16:15

Update screenshots

2103306

Room directory : more cleanup and more tests

42004f2

ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Mar 28, 2024

ganfra marked this pull request as ready for review March 28, 2024 17:15

ganfra requested a review from a team as a code owner March 28, 2024 17:15

ganfra requested review from jmartinesp and removed request for a team March 28, 2024 17:15

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Mar 28, 2024

Update screenshots

d94f4b0

bmarty approved these changes Mar 28, 2024

View reviewed changes

ganfra added 3 commits March 29, 2024 11:37

RoomDirectory : address pr reviews

5f8b740

RoomDirectory : use same logic for name description computation

d34c460

Room directory : fix ci

11dfb32

ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 29, 2024

ganfra enabled auto-merge March 29, 2024 10:51

github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 29, 2024

ganfra added 2 commits March 29, 2024 16:17

RoomDirectory : fix maestro (search screen is closed automatically)

ff9603f

RoomDirectory : set default value of FeatureFlag to false.

8325583

ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 29, 2024

github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 29, 2024

ganfra merged commit a9f326c into develop Mar 29, 2024
19 checks passed

ganfra deleted the feature/fga/room_directory branch March 29, 2024 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/fga/room directory #2620

Feature/fga/room directory #2620

ganfra commented Mar 28, 2024 •

edited

bmarty left a comment

bmarty Mar 28, 2024

bmarty Mar 28, 2024

bmarty Mar 28, 2024

bmarty Mar 28, 2024

bmarty Mar 28, 2024

ElementBot commented Mar 29, 2024 •

edited

github-actions bot commented Mar 29, 2024 •

edited

sonarcloud bot commented Mar 29, 2024

codecov bot commented Mar 29, 2024

	description = "Allow user to search for public rooms in his homeserver",
	description = "Allow user to search for public rooms in their homeserver",

Feature/fga/room directory #2620

Feature/fga/room directory #2620

Conversation

ganfra commented Mar 28, 2024 • edited

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

bmarty left a comment

Choose a reason for hiding this comment

bmarty Mar 28, 2024

Choose a reason for hiding this comment

bmarty Mar 28, 2024

Choose a reason for hiding this comment

bmarty Mar 28, 2024

Choose a reason for hiding this comment

bmarty Mar 28, 2024

Choose a reason for hiding this comment

bmarty Mar 28, 2024

Choose a reason for hiding this comment

ElementBot commented Mar 29, 2024 • edited

github-actions bot commented Mar 29, 2024 • edited

sonarcloud bot commented Mar 29, 2024

Quality Gate passed

codecov bot commented Mar 29, 2024

Codecov Report

ganfra commented Mar 28, 2024 •

edited

ElementBot commented Mar 29, 2024 •

edited

github-actions bot commented Mar 29, 2024 •

edited