Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide call member events #2639

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Hide call member events #2639

merged 5 commits into from
Apr 2, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 2, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • First commit is preparatory work around permalink. It will be need to properly handle permalink computation, when it will be done by the SDK. Need to do this rework now to avoid a circular dependency (see 2nd commit)
  • Second commit: move filtered Event configuration to the appconfig module
  • Third commit: fixes The timeline is rendering event org.matrix.msc3401.call.member #2625

Motivation and context

Fixes #2625 and prepare work around permalink

Screenshots / GIFs

No impact.

Tests

  • In a room with a call, observe the the CallMember Events are not rendered anymore.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

bmarty and others added 3 commits April 2, 2024 14:15
…to the `impl` project in order to remove projects.appconfig dependency from matrix.api module.
It has to become an android module to be able to add a dependency on : libraries:matrix:api.
@bmarty bmarty requested a review from a team as a code owner April 2, 2024 12:40
@bmarty bmarty requested review from jmartinesp and removed request for a team April 2, 2024 12:40
Copy link
Contributor

github-actions bot commented Apr 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mWeioe

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 79.71014% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 73.23%. Comparing base (a9f326c) to head (8e7fdc8).
Report is 5 commits behind head on develop.

Files Patch % Lines
...ent/android/libraries/textcomposer/TextComposer.kt 50.00% 2 Missing and 1 partial ⚠️
...pl/messagecomposer/MessageComposerStateProvider.kt 33.33% 2 Missing ⚠️
...libraries/deeplink/usecase/InviteFriendsUseCase.kt 0.00% 2 Missing ⚠️
...ries/matrix/test/permalink/FakePermalinkBuilder.kt 50.00% 2 Missing ⚠️
.../impl/timeline/components/ATimelineItemEventRow.kt 0.00% 1 Missing ⚠️
...meline/factories/event/TimelineItemEventFactory.kt 50.00% 0 Missing and 1 partial ⚠️
...s/messages/impl/timeline/model/InReplyToDetails.kt 50.00% 0 Missing and 1 partial ⚠️
...aries/matrix/test/permalink/FakePermalinkParser.kt 75.00% 1 Missing ⚠️
...aries/textcomposer/mentions/MentionSpanProvider.kt 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2639      +/-   ##
===========================================
- Coverage    73.31%   73.23%   -0.09%     
===========================================
  Files         1428     1428              
  Lines        34661    34585      -76     
  Branches      6718     6682      -36     
===========================================
- Hits         25412    25328      -84     
- Misses        5743     5763      +20     
+ Partials      3506     3494      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

/**
* Try to convert a URL from an element web instance or from a client permalink to a matrix.to url.
* To be successfully converted, URL path should contain one of the [SUPPORTED_PATHS].
* To be successfully converted, URL path should contain one of the [DefaultMatrixToConverter.SUPPORTED_PATHS].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we move the constant here, or maybe not mention the concrete implementation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the comment.

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 2, 2024
@bmarty bmarty enabled auto-merge April 2, 2024 14:04
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 2, 2024
@bmarty bmarty disabled auto-merge April 2, 2024 14:14
@bmarty bmarty merged commit 609f636 into develop Apr 2, 2024
17 of 18 checks passed
@bmarty bmarty deleted the feature/bma/hideCallMemberEvents branch April 2, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The timeline is rendering event org.matrix.msc3401.call.member
2 participants