-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide call member events #2639
Hide call member events #2639
Conversation
…to the `impl` project in order to remove projects.appconfig dependency from matrix.api module.
It has to become an android module to be able to add a dependency on : libraries:matrix:api.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2639 +/- ##
===========================================
- Coverage 73.31% 73.23% -0.09%
===========================================
Files 1428 1428
Lines 34661 34585 -76
Branches 6718 6682 -36
===========================================
- Hits 25412 25328 -84
- Misses 5743 5763 +20
+ Partials 3506 3494 -12 ☔ View full report in Codecov by Sentry. |
/** | ||
* Try to convert a URL from an element web instance or from a client permalink to a matrix.to url. | ||
* To be successfully converted, URL path should contain one of the [SUPPORTED_PATHS]. | ||
* To be successfully converted, URL path should contain one of the [DefaultMatrixToConverter.SUPPORTED_PATHS]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we move the constant here, or maybe not mention the concrete implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the comment.
…TED_PATHS` in `MatrixToConverter`
Quality Gate passedIssues Measures |
Type of change
Content
org.matrix.msc3401.call.member
#2625Motivation and context
Fixes #2625 and prepare work around permalink
Screenshots / GIFs
No impact.
Tests
Tested devices
Checklist