Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy permalink #2653

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Copy permalink #2653

merged 2 commits into from
Apr 3, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 3, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add action on message bottom sheet to copy permalink on some Event.

Motivation and context

Closes #2650

Screenshots / GIFs

See recorded one

Tests

  • Long click on a message and observe that there is a new action to copy the permalink.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner April 3, 2024 14:25
@bmarty bmarty requested review from jmartinesp and removed request for a team April 3, 2024 14:25
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Apr 3, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GQW9Rc

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.37%. Comparing base (a65e073) to head (ed9384b).
Report is 2 commits behind head on develop.

Files Patch % Lines
...ndroid/features/messages/impl/MessagesPresenter.kt 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2653   +/-   ##
========================================
  Coverage    73.37%   73.37%           
========================================
  Files         1459     1459           
  Lines        35177    35194   +17     
  Branches      6752     6756    +4     
========================================
+ Hits         25812    25825   +13     
- Misses        5851     5853    +2     
- Partials      3514     3516    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 4a27038 into develop Apr 3, 2024
17 checks passed
@bmarty bmarty deleted the feature/bma/copyPermalink branch April 3, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Copy permalink for Event
3 participants