Remove Room moderation feature flag

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Removes the feature flag for room moderation, to make this feature available to everyone.

Motivation and context

The feature is complete and validated.

Screenshots / GIFs

Tests

• Open a room where you're and admin.
• You should have access to room moderation.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4UrdFz

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.55%. Comparing base (46bb960) to head (44bd1ce).
Report is 2 commits behind head on develop.

Files	Patch %	Lines
.../features/roomdetails/impl/RoomDetailsPresenter.kt	0.00%	0 Missing and 1 partial ⚠️
...oderation/DefaultRoomMembersModerationPresenter.kt	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2678      +/-   ##
===========================================
- Coverage    73.56%   73.55%   -0.02%     
===========================================
  Files         1458     1458              
  Lines        35222    35207      -15     
  Branches      6766     6765       -1     
===========================================
- Hits         25912    25897      -15     
+ Misses        5787     5786       -1     
- Partials      3523     3524       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

LGTM, can you add a file for towncrier please?

[bmarty]

Out of scope of this PR, but the condition room.isEncrypted above is a bit strange.

[jmartinesp]

At this point I'm not even sure what a DM should be. It started as a direct room with 2 users and encryption, but I'm not sure if we dropped the encryption check or we still use it...

[jmartinesp]

Maestro died at the same point twice, it seems like the verification screen takes way too long to load...

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud