Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display members section when there are members in the room, not admins #2679

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

jmartinesp
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fixes a typo in the code that made room members appear in the change roles screen only if there were admins in the room.

Motivation and context

See contents.

Tests

  • Enter a room with only admin/moderators.
  • Verify the Members section title is not visible.

Optionally:

  • Enter a room with no admins.
  • Verify the member section is populated.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner April 9, 2024 12:23
@jmartinesp jmartinesp requested review from ganfra and removed request for a team April 9, 2024 12:23
Copy link
Contributor

github-actions bot commented Apr 9, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/BhY9dE

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 9, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) April 9, 2024 12:42
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 9, 2024
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.56%. Comparing base (46bb960) to head (ba9384c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2679   +/-   ##
========================================
  Coverage    73.56%   73.56%           
========================================
  Files         1458     1458           
  Lines        35222    35222           
  Branches      6766     6766           
========================================
  Hits         25912    25912           
  Misses        5787     5787           
  Partials      3523     3523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp merged commit 63f7def into develop Apr 9, 2024
19 checks passed
@jmartinesp jmartinesp deleted the fix/jme/display-members-in-change-roles-screen branch April 9, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants