Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve designs of FTUE analytics opt-in screen #2684

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

jmartinesp
Copy link
Contributor

@jmartinesp jmartinesp commented Apr 10, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : UI improvement

Content

  • Adds gradient background to the FTUE analytics opt-in screen.
  • Changes the icons used in that same screen.
  • Adjusts paddings, background colors and text sizes in InfoListMolecule and InfoListOrganism.

Motivation and context

Makes the UI follow the latest design changes, following what was done in #2581.

Screenshots / GIFs

Before After

Tests

  • Log into a new account.
  • Follow the FTUE process.
  • Check the screen looks as expected.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner April 10, 2024 06:50
@jmartinesp jmartinesp requested review from ganfra and removed request for a team April 10, 2024 06:50
Copy link
Contributor

github-actions bot commented Apr 10, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vfikF7

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (cf072fa) to head (77de187).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2684   +/-   ##
========================================
  Coverage    73.57%   73.57%           
========================================
  Files         1460     1460           
  Lines        35323    35317    -6     
  Branches      6792     6790    -2     
========================================
- Hits         25988    25984    -4     
  Misses        5795     5795           
+ Partials      3540     3538    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jmartinesp jmartinesp enabled auto-merge (squash) April 10, 2024 08:24
@jmartinesp jmartinesp merged commit 6db513c into develop Apr 10, 2024
16 checks passed
@jmartinesp jmartinesp deleted the misc/jme/improve-analytics-opt-in-screen branch April 10, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants