Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound: add SuperButton and GradientFAB components #2696

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

jmartinesp
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Compound: add SuperButton and GradientFAB components
  • Also add ButtonSize.Small and adjust existing Button component

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

jmartinesp and others added 2 commits April 12, 2024 17:01
…ents

Also add `ButtonSize.Small` and adjust existing `Button` component
Copy link
Contributor

github-actions bot commented Apr 12, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bCkX8A

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 89.01099% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 73.62%. Comparing base (f0cf129) to head (88b3c33).
Report is 53 commits behind head on develop.

Files Patch % Lines
...ries/designsystem/components/button/SuperButton.kt 88.00% 2 Missing and 4 partials ⚠️
.../components/button/GradientFloatingActionButton.kt 88.57% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2696      +/-   ##
===========================================
+ Coverage    73.58%   73.62%   +0.03%     
===========================================
  Files         1460     1462       +2     
  Lines        35335    35426      +91     
  Branches      6792     6808      +16     
===========================================
+ Hits         26000    26081      +81     
- Misses        5796     5799       +3     
- Partials      3539     3546       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty marked this pull request as ready for review April 15, 2024 12:18
@bmarty bmarty requested a review from a team as a code owner April 15, 2024 12:18
@bmarty bmarty requested review from ganfra and removed request for a team April 15, 2024 12:18
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bmarty bmarty merged commit 1286ea7 into develop Apr 15, 2024
16 checks passed
@bmarty bmarty deleted the misc/add-super-button-component branch April 15, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants