Permalink navigation - Navigation to rooms and users #2713

bmarty · 2024-04-16T10:34:08Z

Handle permalink navigation to rooms and users
Introduce RoomAlias value class and move many String to RoomAlias
Introduce RoomIdOrAlias
Simplify PermalinkData classes
Waiting for SDK to be ready, API usage has been commented out.

github-actions · 2024-04-17T14:58:56Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/rrdhfV

ganfra

Good work, thanks!
Some first remarks

appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt

appnav/src/main/kotlin/io/element/android/appnav/room/RoomFlowNode.kt

appnav/src/main/kotlin/io/element/android/appnav/room/joined/JoinedRoomLoadedFlowNode.kt

appnav/src/main/kotlin/io/element/android/appnav/room/resolver/ResolveRoomModule.kt

appnav/src/main/kotlin/io/element/android/appnav/room/resolver/RoomAliasResolverView.kt

ganfra · 2024-04-17T16:05:29Z

.../joinroom/api/src/main/kotlin/io/element/android/features/joinroom/api/JoinRoomEntryPoint.kt

 import java.util.Optional

 interface JoinRoomEntryPoint : FeatureEntryPoint {
    fun createNode(parentNode: Node, buildContext: BuildContext, inputs: Inputs): Node

    data class Inputs(
        val roomId: RoomId,
+        val roomIdOrAlias: RoomIdOrAlias,


I'd use an Optional<RoomAlias> instead

That would be more correct, hence it brings some complexity.
At some point the room resolver should probably be moved in the joinroom module (I am more and more convinced about this approach), and so, the first param roomId should just be removed.

...joinroom/impl/src/main/kotlin/io/element/android/features/joinroom/impl/JoinRoomPresenter.kt

...ures/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesNode.kt

- prepare navigating to an Event - add NodeBuilder to MessagesEntryPoint

codecov · 2024-04-17T23:23:40Z

Codecov Report

Attention: Patch coverage is 73.04348% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 73.45%. Comparing base (0cda5b9) to head (4e55c9a).
Report is 9 commits behind head on develop.

Files	Patch %	Lines
...es/roomaliasresolver/impl/RoomAliasResolverView.kt	50.00%	3 Missing and 22 partials ⚠️
...ent/android/features/joinroom/impl/JoinRoomView.kt	76.47%	2 Missing and 10 partials ⚠️
...esolver/impl/DefaultRoomAliasResolverEntryPoint.kt	0.00%	8 Missing ⚠️
...eatures/messages/impl/DefaultMessagesEntryPoint.kt	0.00%	7 Missing ⚠️
...ndroid/features/joinroom/impl/JoinRoomPresenter.kt	79.16%	1 Missing and 4 partials ⚠️
...libraries/matrix/api/room/alias/MatrixRoomAlias.kt	0.00%	4 Missing and 1 partial ⚠️
...omaliasresolver/impl/di/RoomAliasResolverModule.kt	0.00%	4 Missing ⚠️
...omaliasresolver/impl/RoomAliasResolverPresenter.kt	82.35%	1 Missing and 2 partials ⚠️
...signsystem/atomic/organisms/RoomPreviewOrganism.kt	84.21%	1 Missing and 2 partials ⚠️
...lement/android/appnav/room/RoomNavigationTarget.kt	50.00%	2 Missing ⚠️
... and 11 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2713      +/-   ##
===========================================
+ Coverage    72.95%   73.45%   +0.49%     
===========================================
  Files         1469     1487      +18     
  Lines        35622    35806     +184     
  Branches      6862     6903      +41     
===========================================
+ Hits         25987    26300     +313     
+ Misses        6085     5883     -202     
- Partials      3550     3623      +73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…crease end padding to ensure that rendering is correct for big numbers.

…rate screenshots.

ganfra

Thanks for the changes, LGTM!

sonarcloud · 2024-04-18T09:16:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

bmarty force-pushed the feature/bma/roomPreview branch from f4b702a to 84d0442 Compare April 17, 2024 14:52

ganfra reviewed Apr 17, 2024

View reviewed changes

bmarty added 27 commits April 18, 2024 00:00

Add MatrixClient.resolveRoomAlias method.

37fa654

Add MatrixClient.getRoomPreview method.

68346dd

Handle permalink navigation - WIP

2a467bd

- prepare navigating to an Event - add NodeBuilder to MessagesEntryPoint

Introduce value class RoomAlias

bd12ff7

Use RoomId and RoomAlias in MatrixRoomInfo

ecd1bf7

Increase usage of RoomAlias

8327ea3

Alias permalink navigation - WIP

ea3a1f3

Simplify PermalinkData, now that we have RoomIdOrAlias interface.

09faa6d

Resolve RoomId in RoomFlowNode.

235ef2a

Introduce RoomAliasResolverNode with error and retry handling.

b1b5c56

Add Retry on Join room node.

6c8c14f

FIXME

d057183

Handle navigation to the same room.

9620382

Add name to call arguments.

b6e3083

Update extension.

b7d214f

Comment out SDK usage.

7a7fb2a

Open any user permalink.

33212a1

Add test on RoomAliasResolverPresenter

6a125bb

Format file.

400299c

Fix JoinRoomPresenterTest

12b2305

Add test to JoinRoomPresenter to cover RoomPreview

2eb545c

Move RoomAliasResolver classes to their own module.

986f20b

Rename eventId to focusedEventId for clarity.

1fcaf90

Avoid providing default value.

8e5ae8d

Remove extra space.

c9580ad

Ignore too generic exceptions (temporary code).

b8d87d4

Rename JoinRoomEvents.Retry to JoinRoomEvents.RetryFetchingContent

234696c

bmarty added 5 commits April 18, 2024 00:04

Use string from Localazy.

2757337

Fix compilation issue after rebase: String -> RoomAlias

cecc6f2

String -> RoomAlias

5aa0ffe

Fix test.

290a054

Fix test.

35de787

bmarty force-pushed the feature/bma/roomPreview branch from 984b197 to 35de787 Compare April 17, 2024 23:00

bmarty and others added 3 commits April 18, 2024 01:27

Add Modifier and preview for RoomPreviewMembersCountMolecule. Also in…

7528bb7

…crease end padding to ensure that rendering is correct for big numbers.

Use PreviewsDayNight instead of PreviewLightDark in order to gene…

bc1c93c

…rate screenshots.

Update screenshots

29fccd3

bmarty changed the title ~~Permalink navigation - WIP~~ Permalink navigation - Navigation to rooms Apr 17, 2024

bmarty changed the title ~~Permalink navigation - Navigation to rooms~~ Permalink navigation - Navigation to rooms and users Apr 17, 2024

bmarty marked this pull request as ready for review April 17, 2024 23:51

bmarty requested a review from a team as a code owner April 17, 2024 23:51

bmarty requested review from ganfra and removed request for a team April 17, 2024 23:51

bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 17, 2024

github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 17, 2024

bmarty and others added 5 commits April 18, 2024 09:04

Readability

b7d4fa6

Fix Preview name

cd63ae8

Order import

82befcb

More complete preview

d2e043f

Update screenshots

b7f5c28

ganfra approved these changes Apr 18, 2024

View reviewed changes

Please ktlint

4e55c9a

bmarty merged commit e7172cb into develop Apr 18, 2024
16 checks passed

bmarty deleted the feature/bma/roomPreview branch April 18, 2024 09:30

This was referenced Apr 19, 2024

[Task] Click on user permalink #2644

Closed

[Task] Click on room permalink #2642

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Permalink navigation - Navigation to rooms and users #2713

Permalink navigation - Navigation to rooms and users #2713

bmarty commented Apr 16, 2024 •

edited

github-actions bot commented Apr 17, 2024 •

edited

ganfra left a comment

ganfra Apr 17, 2024

bmarty Apr 17, 2024

codecov bot commented Apr 17, 2024 •

edited

ganfra left a comment

sonarcloud bot commented Apr 18, 2024

Permalink navigation - Navigation to rooms and users #2713

Permalink navigation - Navigation to rooms and users #2713

Conversation

bmarty commented Apr 16, 2024 • edited

github-actions bot commented Apr 17, 2024 • edited

ganfra left a comment

Choose a reason for hiding this comment

ganfra Apr 17, 2024

Choose a reason for hiding this comment

bmarty Apr 17, 2024

Choose a reason for hiding this comment

codecov bot commented Apr 17, 2024 • edited

Codecov Report

ganfra left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Apr 18, 2024

Quality Gate passed

bmarty commented Apr 16, 2024 •

edited

github-actions bot commented Apr 17, 2024 •

edited

codecov bot commented Apr 17, 2024 •

edited