Iterate on loadingNode to render the same way JoinRoomView will render
#2741
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2741 +/- ##
========================================
Coverage 73.50% 73.50%
========================================
Files 1490 1490
Lines 35881 35881
Branches 6924 6924
========================================
Hits 26376 26376
Misses 5872 5872
Partials 3633 3633 ☔ View full report in Codecov by Sentry. |
bmarty
force-pushed
the
feature/bma/removeRoomFlowNodeLoading
branch
from
b4fa3e1
to
f2a0744
Compare
bmarty
added
the
Record-Screenshots
github-actions
bot
removed
the
Record-Screenshots
|
Not sure this is correct. Looks to have the wrong placeholder for me |
|
@frebib you're right, good catch, thanks! Let's iterate to look more like the existing room loading view, which will be more frequent than clicking on an unknown room permalink. |
bmarty
force-pushed
the
feature/bma/removeRoomFlowNodeLoading
branch
from
9690fcc
to
1ffa6c5
Compare
|
| val networkStatus by networkMonitor.connectivity.collectAsState() | ||
| LoadingRoomNodeView( | ||
| state = LoadingRoomState.Loading, | ||
| hasNetworkConnection = networkStatus == NetworkStatus.Online, |
There was a problem hiding this comment.
This is a bit weird to show the hasNetwork connection here and not in room preview :/
There was a problem hiding this comment.
It's OK I think since the network status is displayed on rooms, and for preview we will get an error anyway (which could be improved, but out of scope of this PR)
We may want to add the network status to room preview if this was what you mean?
Ready to be reviewed.