Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ui test on DeveloperSettingsView #2744

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 23, 2024

No more to say. Should increase coverage, which was not good for TextFieldDialog

image

@bmarty bmarty requested a review from a team as a code owner April 23, 2024 11:58
@bmarty bmarty requested review from ganfra and removed request for a team April 23, 2024 11:58
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.60%. Comparing base (e0d40ec) to head (d06ec90).
Report is 19 commits behind head on develop.

Files Patch % Lines
...stem/components/preferences/PreferenceTextField.kt 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2744      +/-   ##
===========================================
+ Coverage    73.50%   73.60%   +0.09%     
===========================================
  Files         1490     1490              
  Lines        35881    35891      +10     
  Branches      6924     6925       +1     
===========================================
+ Hits         26376    26416      +40     
+ Misses        5872     5829      -43     
- Partials      3633     3646      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/UtDNeD

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 23, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 23, 2024
@bmarty
Copy link
Member Author

bmarty commented Apr 23, 2024

Maestro failure has been fixed in #2743

@bmarty bmarty merged commit 3438b98 into develop Apr 24, 2024
18 of 20 checks passed
@bmarty bmarty deleted the feature/bma/testPreferenceTextField branch April 24, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants