-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Verification state analytics #2806
Add support for Verification state analytics #2806
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2806 +/- ##
===========================================
+ Coverage 73.44% 73.50% +0.05%
===========================================
Files 1523 1524 +1
Lines 36513 36559 +46
Branches 7032 7045 +13
===========================================
+ Hits 26816 26871 +55
+ Misses 6028 6010 -18
- Partials 3669 3678 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it would be nice to add some more tests since the coverage of the PR is a bit low.
...in/kotlin/io/element/android/services/analyticsproviders/posthog/PosthogAnalyticsProvider.kt
Outdated
Show resolved
Hide resolved
appnav/src/test/kotlin/io/element/android/appnav/loggedin/LoggedInPresenterTest.kt
Outdated
Show resolved
Hide resolved
appnav/src/main/kotlin/io/element/android/appnav/loggedin/AnalyticsVerificationStateExt.kt
Show resolved
Hide resolved
|
Quality Gate passedIssues Measures |
Add support to report the current verification and recovery state of a user.
This will allow to get some analytics on users that are not in a complete state for recovery.
Updated analytics event to latest version 0.21.0
Udpated
PosthogAnalyticsProvider
to properly support UserProperties, Added some tests for that.Using
LoggedInPresenter
as entry point to report.Type of change
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist