Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Verification state analytics #2806

Merged
merged 4 commits into from
May 7, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented May 6, 2024

Add support to report the current verification and recovery state of a user.
This will allow to get some analytics on users that are not in a complete state for recovery.

Updated analytics event to latest version 0.21.0
Udpated PosthogAnalyticsProvider to properly support UserProperties, Added some tests for that.

Using LoggedInPresenter as entry point to report.

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner May 6, 2024 17:10
@BillCarsonFr BillCarsonFr requested review from jmartinesp and removed request for a team May 6, 2024 17:10
Copy link
Contributor

github-actions bot commented May 6, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/teeifP

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 73.50%. Comparing base (3435803) to head (a8f5c8d).
Report is 7 commits behind head on develop.

Files Patch % Lines
...yticsproviders/posthog/PosthogAnalyticsProvider.kt 66.66% 0 Missing and 4 partials ⚠️
...ement/android/appnav/loggedin/LoggedInPresenter.kt 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2806      +/-   ##
===========================================
+ Coverage    73.44%   73.50%   +0.05%     
===========================================
  Files         1523     1524       +1     
  Lines        36513    36559      +46     
  Branches      7032     7045      +13     
===========================================
+ Hits         26816    26871      +55     
+ Misses        6028     6010      -18     
- Partials      3669     3678       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be nice to add some more tests since the coverage of the PR is a bit low.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 7, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 7, 2024
@ElementBot
Copy link
Collaborator

ElementBot commented May 7, 2024

Warnings
⚠️

gradle/libs.versions.toml#L6 - A newer version of com.android.tools.build:gradle than 8.3.2 is available: 8.4.0

⚠️

gradle/libs.versions.toml#L9 - A newer version of com.google.firebase:firebase-appdistribution-gradle than 4.2.0 is available: 5.0.0

⚠️

gradle/libs.versions.toml#L12 - A newer version of androidx.core:core-ktx than 1.13.0 is available: 1.13.1

⚠️

gradle/libs.versions.toml#L18 - A newer version of androidx.datastore:datastore-preferences than 1.0.0 is available: 1.1.1

⚠️

gradle/libs.versions.toml#L22 - A newer version of androidx.activity:activity-compose than 1.8.2 is available: 1.9.0

⚠️

gradle/libs.versions.toml#L71 - A newer version of com.google.firebase:firebase-bom than 32.8.1 is available: 33.0.0

⚠️

gradle/libs.versions.toml#L99 - A newer version of androidx.webkit:webkit than 1.10.0 is available: 1.11.0

Generated by 🚫 dangerJS against a8f5c8d

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 7, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 7, 2024
@BillCarsonFr BillCarsonFr merged commit 2007752 into develop May 7, 2024
19 checks passed
@BillCarsonFr BillCarsonFr deleted the feature/valere/report_crypto_status_analytics branch May 7, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants