Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce mandatory session verification only for new logins #2811

Merged
merged 4 commits into from
May 7, 2024
Merged

Enforce mandatory session verification only for new logins #2811

merged 4 commits into from
May 7, 2024

Commits on May 7, 2024

  1. Enforce mandatory session verification only for new logins 

    - Creates `AppMigration` base interface as a way to isolate migration logic, app migrations must implement this interface.
- Creates `AppMigration01` with the existing logs removal migration and `AppMigration02` with the logic to allow existing sessions to skip verification.
- Add `DefaultSessionPreferencesStoreFactory.remove(sessionId)` to allow a ephemeral session store access to exist outside the `SessionScope` for this new migration.
    @jmartinesp
    jmartinesp committed May 7, 2024
    Configuration menu
    Copy the full SHA
    e9b854b View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @jmartinesp
    jmartinesp committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6368cc3 View commit details
    Browse the repository at this point in the history

  3. Add more tests. 

    This also includes creating several abstractions.
    @jmartinesp
    jmartinesp committed May 7, 2024
    Configuration menu
    Copy the full SHA
    de0bc14 View commit details
    Browse the repository at this point in the history

  4. Review changes. 

    - Make `orderedMigrations` a class property, `migrations` just a constructor parameter to avoid incorrect usages.
- Create `lastMigration` property too, use it instead of `MIGRATION_VERSION`.
    @jmartinesp
    jmartinesp committed May 7, 2024
    Configuration menu
    Copy the full SHA
    fc6937d View commit details
    Browse the repository at this point in the history