Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add room badges #2822

Merged
merged 5 commits into from
May 9, 2024
Merged

Add room badges #2822

merged 5 commits into from
May 9, 2024

Conversation

jmartinesp
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other: UI improvements

Content

Motivation and context

Update the designs so they match the current ones in Figma.

Screenshots / GIFs

Before After

Tests

  • Open several rooms.
  • Check the new badges are displayed when necessary.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner May 8, 2024 16:12
@jmartinesp jmartinesp requested review from bmarty and removed request for a team May 8, 2024 16:12
@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 8, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/aqWKng

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 87.05882% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 73.96%. Comparing base (4c1bd2d) to head (381b7df).

Files Patch % Lines
...android/libraries/designsystem/components/Badge.kt 69.56% 0 Missing and 7 partials ⚠️
...droid/features/roomdetails/impl/RoomDetailsView.kt 92.85% 0 Missing and 2 partials ⚠️
.../features/roomdetails/impl/components/RoomBadge.kt 90.90% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2822      +/-   ##
===========================================
+ Coverage    73.93%   73.96%   +0.03%     
===========================================
  Files         1528     1530       +2     
  Lines        36467    36549      +82     
  Branches      7053     7075      +22     
===========================================
+ Hits         26961    27034      +73     
+ Misses        5811     5810       -1     
- Partials      3695     3705      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp merged commit 48bb0f4 into develop May 9, 2024
19 checks passed
@jmartinesp jmartinesp deleted the misc/jme/ux-cleanup-add-room-badges branch May 9, 2024 06:38
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants