Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's not possible to join room from the RoomDirectory screen anymore. #2839

Merged
merged 2 commits into from
May 14, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 14, 2024

Cleanup after #2827

@bmarty bmarty requested a review from a team as a code owner May 14, 2024 08:22
@bmarty bmarty requested review from jmartinesp and removed request for a team May 14, 2024 08:22
@bmarty bmarty force-pushed the feature/bma/removeDeadCode branch from 37cd3e1 to 5814de1 Compare May 14, 2024 08:23
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 14, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 14, 2024
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/JBbyYW

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.95%. Comparing base (f063268) to head (0148224).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2839      +/-   ##
===========================================
- Coverage    73.96%   73.95%   -0.01%     
===========================================
  Files         1531     1531              
  Lines        36536    36505      -31     
  Branches      7074     7069       -5     
===========================================
- Hits         27024    26999      -25     
+ Misses        5809     5804       -5     
+ Partials      3703     3702       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 14, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 14, 2024
Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! I left if there in case we wanted to re-enable it in the future with some other UI, but it's probably not the case so it's better to just get rid of it.

@bmarty bmarty merged commit 231f323 into develop May 14, 2024
20 checks passed
@bmarty bmarty deleted the feature/bma/removeDeadCode branch May 14, 2024 09:14
@bmarty
Copy link
Member Author

bmarty commented May 14, 2024

(Yes, I needed to do some cleanup to simplify another coming PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants