Timeline : remove some code from main thread #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2841 +/- ##
========================================
Coverage 73.95% 73.95%
========================================
Files 1531 1531
Lines 36505 36505
Branches 7069 7069
========================================
Hits 26999 26999
Misses 5804 5804
Partials 3702 3702 ☔ View full report in Codecov by Sentry. |
bmarty
added
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
bmarty
approved these changes
May 14, 2024
| Timber.d("Can't paginate $direction on room ${matrixRoom.roomId} with paginationStatus: ${backPaginationStatus.value}") | ||
| } else { | ||
| Timber.e(error, "Error paginating $direction on room ${matrixRoom.roomId}") | ||
| withContext(dispatcher) { |
There was a problem hiding this comment.
Can be written like this: withContext(NonCancellable + dispatcher) { I think, but not a big deal as using NonCancellable is a temporary workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just small clean up of code launched on main thread.