Provide serverNames when available and fix issue around analytics

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

The serverNames (AKA as via parameter) was not provided to the join room API.

This PR ensure that it is provided by using the new API joinRoomByIdOrAlias.

This is centralized in DefaultJoinRoom, which is also taking care of the analytics. Previously AcceptDeclineInvitePresenter was always used to join a Room and so JoinedRoom.Trigger.Invite was always sent to analytics, which was not correct.

Motivation and context

Give more chance for the join room to work, if the homerver does not know the RoomId.

Screenshots / GIFs

NA

Tests

• Join a room using a permalink
• Join a room when invited

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/F4uS1Z

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 73.99%. Comparing base (231f323) to head (80279c9).
Report is 8 commits behind head on develop.

Files	Patch %	Lines
...ndroid/features/joinroom/impl/di/JoinRoomModule.kt	0.00%	3 Missing ⚠️
...roid/libraries/matrix/api/analytics/ViewRoomExt.kt	0.00%	3 Missing ⚠️
...ndroid/features/joinroom/api/JoinRoomEntryPoint.kt	0.00%	2 Missing ⚠️
.../android/libraries/matrix/test/FakeMatrixClient.kt	60.00%	2 Missing ⚠️
...ent/android/features/joinroom/impl/JoinRoomView.kt	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2843      +/-   ##
===========================================
+ Coverage    73.95%   73.99%   +0.03%     
===========================================
  Files         1531     1531              
  Lines        36505    36526      +21     
  Branches      7069     7065       -4     
===========================================
+ Hits         26999    27028      +29     
+ Misses        5804     5796       -8     
  Partials      3702     3702              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.