Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issue introduced in #2924. #2939

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 29, 2024

This code is not used yet, and also the value will always be the same for the 2 API, but let's use the correct API anyway.

@bmarty bmarty requested a review from a team as a code owner May 29, 2024 12:27
@bmarty bmarty requested review from jmartinesp and removed request for a team May 29, 2024 12:27
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, nice catch!

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.28%. Comparing base (a1adc74) to head (8c3bb04).

Files Patch % Lines
...mpl/notifications/NotificationBroadcastReceiver.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2939   +/-   ##
========================================
  Coverage    75.28%   75.28%           
========================================
  Files         1545     1545           
  Lines        36823    36823           
  Branches      7142     7142           
========================================
  Hits         27721    27721           
  Misses        5368     5368           
  Partials      3734     3734           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 994b701 into develop May 29, 2024
20 of 22 checks passed
@bmarty bmarty deleted the feature/bma/fixWrongApiUsage branch May 29, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants