Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to workaround OOM errors and the runners dying #3013

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

jmartinesp
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Splits sonar job in several steps so the daemon gets 'restarted' and frees up some memory.
  • Same for Android lint.
  • For Android lint, disable checkDependencies.

With these changes all CI jobs should pass again (for now).

Motivation and context

Once again we have issues where either we get OOM errors if the max heap size is too low or we bump it to 7GB and the runner dies (even though technically it should have 14GB for us, so maybe the kotlin compiler takes the rest).

I still don't really understand what's happening to be honest, because locally the RAM memory usage I get when running the same CI jobs are way lower (as in, almost half). This might be related to some bug on AGP, or some other plugin, no idea...

Tests

All CI jobs should be green.

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner June 11, 2024 15:44
@jmartinesp jmartinesp requested review from ganfra and removed request for a team June 11, 2024 15:44
Copy link
Contributor

github-actions bot commented Jun 11, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/1BQYrc

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.78%. Comparing base (756905b) to head (25034e5).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3013      +/-   ##
===========================================
- Coverage    75.78%   75.78%   -0.01%     
===========================================
  Files         1611     1611              
  Lines        38098    38098              
  Branches      7362     7362              
===========================================
- Hits         28872    28871       -1     
  Misses        5374     5374              
- Partials      3852     3853       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Add `-XX:MaxMetaspaceSize` (gradle/gradle#19750)
- Remove `-PpreDexEnable` as it's deprecated and no longer used.
- Remove `--max-workers` as gradle will automatically use the optimal amount.
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 12, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 12, 2024
@ganfra
Copy link
Contributor

ganfra commented Jun 12, 2024

@jmartinesp record screenshots failed somehow

@jmartinesp
Copy link
Contributor Author

@jmartinesp record screenshots failed somehow

It failed because it had nothing to commit, but the gradle runs worked fine which is what I wanted to test.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 12, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 12, 2024
Copy link
Contributor

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok lets merge!

@jmartinesp jmartinesp merged commit c9e0db2 into develop Jun 12, 2024
27 of 28 checks passed
@jmartinesp jmartinesp deleted the misc/jme/workaround-ci-memory-leaks-again branch June 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants