Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve room filtering behavior. #3083

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 24, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure that when clicking on filter "Favorite" in the room list, the list of filter is rendered correctly.

Motivation and context

Improve UX

Screenshots / GIFs

Before After
RoomFilterBefore RoomFilter

Tests

  • Open the room list and play with the filters:
    • scroll to the right and click on Favorites
    • when the "close" button is displayed, scroll a bit and then click on it.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner June 24, 2024 13:40
@bmarty bmarty requested review from jmartinesp and removed request for a team June 24, 2024 13:40
Copy link
Contributor

github-actions bot commented Jun 24, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xyDoEa

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.93%. Comparing base (cb14be2) to head (c0a6bcf).
Report is 24 commits behind head on develop.

Files Patch % Lines
...tures/roomlist/impl/filters/RoomListFiltersView.kt 57.14% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3083      +/-   ##
===========================================
- Coverage    75.94%   75.93%   -0.01%     
===========================================
  Files         1633     1633              
  Lines        38589    38603      +14     
  Branches      7460     7462       +2     
===========================================
+ Hits         29305    29313       +8     
- Misses        5394     5398       +4     
- Partials      3890     3892       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 24, 2024

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 25, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 25, 2024
Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmarty bmarty merged commit e7f7493 into develop Jun 26, 2024
26 of 27 checks passed
@bmarty bmarty deleted the feature/bma/filterAutoScroll branch June 26, 2024 07:46
@ganfra ganfra added the PR-Misc For other changes label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants