Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable kotlin incremental compilation for now, waiting for better #564

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

ganfra
Copy link
Contributor

@ganfra ganfra commented Jun 8, 2023

See here for the reason.
If it ends up being too slow we might want to -Pkotlin.incremental=false command line argument when needed instead.

@ganfra ganfra marked this pull request as ready for review June 8, 2023 13:13
@ganfra ganfra requested a review from a team as a code owner June 8, 2023 13:13
@ganfra ganfra requested review from jmartinesp and removed request for a team June 8, 2023 13:13
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/JwSsoB

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a2c13ed) 53.24% compared to head (27c8729) 53.24%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #564   +/-   ##
========================================
  Coverage    53.24%   53.24%           
========================================
  Files          752      752           
  Lines        18081    18081           
  Branches      3850     3850           
========================================
  Hits          9627     9627           
  Misses        6871     6871           
  Partials      1583     1583           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hopefully this should workaround the issue until a proper fix is released.

@ganfra ganfra merged commit 3dae38e into develop Jun 8, 2023
12 checks passed
@ganfra ganfra deleted the feature/fga/fix_anvil_incremental_changes branch June 8, 2023 13:57
bmarty pushed a commit that referenced this pull request Jul 19, 2023
…tal_changes

Disable kotlin incremental compilation for now, waiting for better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants