New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screenshot tests #130
Screenshot tests #130
Conversation
Generated by 🚫 Danger Swift against 26b4024 |
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YNS3GE |
1ecf993
to
c5872b1
Compare
b531fad
to
875be75
Compare
Codecov Report
@@ Coverage Diff @@
## develop #130 +/- ##
===========================================
- Coverage 35.01% 27.71% -7.30%
===========================================
Files 168 170 +2
Lines 11741 11757 +16
Branches 5747 5745 -2
===========================================
- Hits 4111 3259 -852
- Misses 7538 8428 +890
+ Partials 92 70 -22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing to see this working, can't wait to use it! 🥳
I've added some comments inline, one thing I haven't added though is that I don't think we should use python 2 for this and should probably switch to python 3 as its more likely someone has installed that.
ElementX/Sources/Other/SwiftUI/Animation/ElementAnimations.swift
Outdated
Show resolved
Hide resolved
a1eb77b
to
4e625ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks for the changes to use python3 🙏
14664f5
to
b5faa7d
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Provides a screenshot testing using https://github.com/pointfreeco/swift-snapshot-testing library. I've configured the tests not to fail for newly-taken screenshots.
Tests run on the matrix of:
Fixes #9
Requires Xcodegen 2.29.0+