Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt fix for unreliable tests #141

Merged
merged 4 commits into from Jul 25, 2022
Merged

Attempt fix for unreliable tests #141

merged 4 commits into from Jul 25, 2022

Conversation

stefanceriu
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 22, 2022

Warnings
⚠️ Please provide a description for this PR.
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against a349e92

@github-actions
Copy link

github-actions bot commented Jul 22, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gf6PN4

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #141 (a349e92) into develop (7d97257) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #141      +/-   ##
===========================================
+ Coverage    35.49%   35.50%   +0.01%     
===========================================
  Files          166      166              
  Lines        11522    11524       +2     
  Branches      5658     5658              
===========================================
+ Hits          4090     4092       +2     
  Misses        7341     7341              
  Partials        91       91              
Impacted Files Coverage Δ
...ation/MockSessionVerificationControllerProxy.swift 95.23% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d97257...a349e92. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu marked this pull request as ready for review July 25, 2022 11:29
@stefanceriu stefanceriu merged commit 0bb7f0e into develop Jul 25, 2022
@stefanceriu stefanceriu deleted the stefan/unitTests branch July 25, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants