Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2414 - Move member loading to the room member detail screen, a… #2425

Merged
merged 2 commits into from Feb 7, 2024

Conversation

stefanceriu
Copy link
Contributor

@stefanceriu stefanceriu commented Feb 6, 2024

…void blocking the whole application

Simulator.Screen.Recording.-.iPhone.15.-.2024-02-07.at.08.40.06.mp4

@stefanceriu stefanceriu requested a review from a team as a code owner February 6, 2024 15:00
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team February 6, 2024 15:00
Copy link

github-actions bot commented Feb 6, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 67c0abe

Copy link
Contributor

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some testing suggestions mostly. Can you also upload a video of the new behaviour for a big room and a small room?

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (f9edb75) 72.99% compared to head (ba4b6f9) 72.74%.

❗ Current head ba4b6f9 differs from pull request most recent head 67c0abe. Consider uploading reports for the commit 67c0abe to get more accurate results

Files Patch % Lines
...tailsScreen/RoomMemberDetailsScreenViewModel.swift 67.34% 16 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 29.41% 12 Missing ⚠️
...ilsScreen/RoomMemberDetailsScreenCoordinator.swift 0.00% 6 Missing ⚠️
...erDetailsScreen/View/RoomMemberDetailsScreen.swift 93.93% 4 Missing ⚠️
...rListScreen/RoomMembersListScreenCoordinator.swift 0.00% 3 Missing ⚠️
...berListScreen/RoomMembersListScreenViewModel.swift 62.50% 3 Missing ⚠️
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 0.00% 2 Missing ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 0.00% 2 Missing ⚠️
...eens/RoomScreen/RoomScreenInteractionHandler.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2425      +/-   ##
===========================================
- Coverage    72.99%   72.74%   -0.26%     
===========================================
  Files          523      523              
  Lines        36191    36238      +47     
  Branches     17413    17419       +6     
===========================================
- Hits         26417    26360      -57     
- Misses        9135     9238     +103     
- Partials       639      640       +1     
Flag Coverage Δ
unittests 58.14% <68.38%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu enabled auto-merge (squash) February 7, 2024 07:13
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu merged commit b075ddb into develop Feb 7, 2024
5 checks passed
@stefanceriu stefanceriu deleted the stefan/memberDetailLoading branch February 7, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants