Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roles and permissions screen #2505

Merged
merged 2 commits into from Feb 27, 2024
Merged

Conversation

pixlwave
Copy link
Contributor

@pixlwave pixlwave commented Feb 27, 2024

This only implements the screen, I'll implement the other screens and then assemble them together with a flow coordinator once they're all done.

This forms the basis for #2356 and #2358.

Screenshot 2024-02-27 at 1 06 50 pm

@pixlwave pixlwave requested a review from a team as a code owner February 27, 2024 13:07
@pixlwave pixlwave requested review from stefanceriu and removed request for a team February 27, 2024 13:07
Copy link

github-actions bot commented Feb 27, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 8a7f73e

The screen hasn't been added to the flows yet.
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 61.15108% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 74.79%. Comparing base (fdbaef5) to head (8a7f73e).
Report is 2 commits behind head on develop.

Files Patch % Lines
...een/RoomRolesAndPermissionsScreenCoordinator.swift 0.00% 25 Missing ⚠️
...creen/RoomRolesAndPermissionsScreenViewModel.swift 51.61% 15 Missing ⚠️
...onsScreen/View/RoomRolesAndPermissionsScreen.swift 83.13% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2505      +/-   ##
===========================================
+ Coverage    74.56%   74.79%   +0.22%     
===========================================
  Files          526      529       +3     
  Lines        36835    36974     +139     
  Branches     17495    17495              
===========================================
+ Hits         27466    27653     +187     
+ Misses        9151     9103      -48     
  Partials       218      218              
Flag Coverage Δ
unittests 60.62% <61.15%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixlwave pixlwave merged commit a0b510c into develop Feb 27, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/roles-and-permissions branch February 27, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants