Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Compound. #2514

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Update Compound. #2514

merged 3 commits into from
Mar 1, 2024

Conversation

pixlwave
Copy link
Contributor

@pixlwave pixlwave commented Feb 29, 2024

This fixes a bug introduced in #2438 where placeholder avatars in notifications looked a bit odd for new rooms due to using a colour with an alpha channel. Requires element-hq/compound-ios#60

notification@2x

@pixlwave pixlwave requested a review from a team as a code owner February 29, 2024 17:33
@pixlwave pixlwave requested review from Velin92 and removed request for a team February 29, 2024 17:33
project.yml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 29, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against a878e82

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.24%. Comparing base (b3e6fdc) to head (a878e82).
Report is 1 commits behind head on develop.

Files Patch % Lines
...urces/Other/Extensions/UNNotificationContent.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2514      +/-   ##
===========================================
+ Coverage    75.15%   75.24%   +0.08%     
===========================================
  Files          530      530              
  Lines        36833    36833              
  Branches     17616    17615       -1     
===========================================
+ Hits         27683    27715      +32     
+ Misses        9150     9118      -32     
Flag Coverage Δ
unittests 60.34% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixlwave pixlwave merged commit ce667ea into develop Mar 1, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/update-compound branch March 1, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants