Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching disables the filters #2530

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

Velin92
Copy link
Contributor

@Velin92 Velin92 commented Mar 5, 2024

Simulator.Screen.Recording.-.iPhone.15.-.2024-03-05.at.17.35.41.mp4

Copy link

github-actions bot commented Mar 5, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 36f5872

@Velin92 Velin92 marked this pull request as ready for review March 5, 2024 16:34
@Velin92 Velin92 requested a review from a team as a code owner March 5, 2024 16:34
@Velin92 Velin92 requested review from pixlwave and removed request for a team March 5, 2024 16:34
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 enabled auto-merge (squash) March 5, 2024 16:38
@Velin92 Velin92 disabled auto-merge March 5, 2024 16:38
Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 75.34%. Comparing base (8c68f5a) to head (36f5872).
Report is 1 commits behind head on develop.

Files Patch % Lines
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% 6 Missing ⚠️
...obalSearchScreen/GlobalSearchScreenViewModel.swift 50.00% 1 Missing ⚠️
...es/Screens/HomeScreen/View/HomeScreenContent.swift 66.66% 1 Missing ⚠️
...rdingScreen/MessageForwardingScreenViewModel.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2530      +/-   ##
===========================================
+ Coverage    75.29%   75.34%   +0.05%     
===========================================
  Files          537      537              
  Lines        37180    37179       -1     
  Branches     17560    17546      -14     
===========================================
+ Hits         27993    28011      +18     
+ Misses        9187     9168      -19     
Flag Coverage Δ
unittests 60.63% <72.72%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit 7754b9b into develop Mar 6, 2024
9 checks passed
@Velin92 Velin92 deleted the mauroromito/remove_filters_while_searching branch March 6, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants