Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters, Mark Unread/Read/Favourites FF removals + code and tests clean up #2541

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

Velin92
Copy link
Contributor

@Velin92 Velin92 commented Mar 7, 2024

The title says it all.
We also removed the user suggestions, since it's a feature that was not completed for quite some time.

I have also run periphery to remove some unused code

@Velin92 Velin92 requested a review from a team as a code owner March 7, 2024 15:09
@Velin92 Velin92 requested review from pixlwave and stefanceriu and removed request for a team March 7, 2024 15:09
Copy link

github-actions bot commented Mar 7, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against c2648c6

Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Velin92 Velin92 enabled auto-merge (squash) March 7, 2024 15:38
@Velin92 Velin92 disabled auto-merge March 7, 2024 15:38
@Velin92 Velin92 enabled auto-merge (squash) March 7, 2024 15:41
@Velin92 Velin92 disabled auto-merge March 7, 2024 16:56
@Velin92 Velin92 merged commit c66ddfb into develop Mar 7, 2024
2 of 3 checks passed
@Velin92 Velin92 deleted the mauroromito/remove_ffs branch March 7, 2024 16:56
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants