Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bugs in the moderation feature. #2608

Merged
merged 12 commits into from
Mar 27, 2024
Merged

Conversation

pixlwave
Copy link
Contributor

@pixlwave pixlwave commented Mar 26, 2024

Fixes the following bugs from element-hq/element-meta#2369

  • Use a consistent string in all member list search fields.
  • Show your own user as an Admin when changing roles.
  • Also show invited users when changing roles.
  • Don't allow admin's to kick/ban other admins (or themselves).
  • Show admin/mod/user sections in the edit roles screen.
  • Show pending users in the edit roles screen.
  • Show selection for disabled members in the edit roles screen.

Additionally fixes a bug where left members were being counted as admins/moderators.

@pixlwave pixlwave requested a review from a team as a code owner March 26, 2024 14:58
@pixlwave pixlwave requested review from stefanceriu and removed request for a team March 26, 2024 14:58
Copy link

github-actions bot commented Mar 26, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/RoomMemberListScreen/View/RoomMembersListManageMemberSheet.swift#L64 - TODOs should be resolved (Use the ideal height somehow?). (todo)

⚠️

ElementX/Sources/Services/Room/RoomMember/RoomMemberDetails.swift#L68 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

⚠️

ElementX/Sources/Services/Room/RoomMember/RoomMemberDetails.swift#L69 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

⚠️

ElementX/Sources/Services/Room/RoomMember/RoomMemberDetails.swift#L70 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

Generated by 🚫 Danger Swift against 5c48fb6

Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🙌

@pixlwave
Copy link
Contributor Author

In fixing the snapshots I ended up including the final part of the changes (Show role of user & show 'not selectable' checkbox) in this PR.

Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pixlwave pixlwave merged commit e424a02 into develop Mar 27, 2024
4 of 5 checks passed
@pixlwave pixlwave deleted the doug/moderation-bugs branch March 27, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants