Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appearance of admins when changing moderators. #2654

Merged
merged 2 commits into from Apr 5, 2024

Conversation

pixlwave
Copy link
Contributor

@pixlwave pixlwave commented Apr 5, 2024

Another tweak for #2548. Includes an update to Compound, but is missing a change for the appearance of pending users.

roomRolesAndPermissionsFlow-2-iPhone-15-en-GB UI

@pixlwave pixlwave requested a review from a team as a code owner April 5, 2024 10:00
@pixlwave pixlwave requested review from stefanceriu and removed request for a team April 5, 2024 10:00
Copy link

github-actions bot commented Apr 5, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against a033914

Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.75%. Comparing base (023b7fc) to head (a033914).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2654      +/-   ##
===========================================
+ Coverage    74.63%   74.75%   +0.12%     
===========================================
  Files          566      566              
  Lines        38726    38737      +11     
  Branches     16221    16221              
===========================================
+ Hits         28902    28957      +55     
+ Misses        9824     9780      -44     
Flag Coverage Δ
unittests 62.16% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 181753e into develop Apr 5, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/compound branch April 5, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants