Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QR Code scan view #2674

Merged
merged 6 commits into from Apr 10, 2024
Merged

QR Code scan view #2674

merged 6 commits into from Apr 10, 2024

Conversation

Velin92
Copy link
Contributor

@Velin92 Velin92 commented Apr 9, 2024

this is just a basic implementation, and does not do anything for now, but its implemented and testable in preview alongside also its substates (.initial, .connecting, .invalid).

@Velin92 Velin92 requested a review from a team as a code owner April 9, 2024 16:19
@Velin92 Velin92 requested review from pixlwave and removed request for a team April 9, 2024 16:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 8486020

pixlwave
pixlwave approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👏

ElementX/Sources/FlowCoordinators/AuthenticationFlowCoordinator.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/QRCodeLoginScreenModels.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/QRCodeLoginScreenViewModel.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/View/QRCodeScannerView.swift Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/View/QRCodeScannerView.swift Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/View/QRCodeLoginScreen.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/View/QRCodeLoginScreen.swift Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/View/QRCodeLoginScreen.swift Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/View/QRCodeLoginScreen.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/QRCodeLoginScreen/View/QRCodeLoginScreen.swift Outdated Show resolved Hide resolved
@Velin92 Velin92 enabled auto-merge (squash) April 10, 2024 10:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 merged commit bcd7e22 into develop Apr 10, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/qr_scanning branch April 10, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Velin92 @pixlwave