Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Update for user profile screen and room member details #2822

Merged
merged 10 commits into from
May 9, 2024

Conversation

Velin92
Copy link
Contributor

@Velin92 Velin92 commented May 9, 2024

This PR also changed the behaviour of the form button style all across the app, and introduced a way to start calls directly when checking a user profile (if a DM already exists)

fixes #2816

@Velin92 Velin92 requested a review from a team as a code owner May 9, 2024 09:22
@Velin92 Velin92 requested review from stefanceriu and removed request for a team May 9, 2024 09:22
@Velin92 Velin92 force-pushed the mauroromito/user_profile_changes branch from 9159497 to eebaa5d Compare May 9, 2024 09:22
Copy link

github-actions bot commented May 9, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e6afcb5

@Velin92 Velin92 requested a review from pixlwave May 9, 2024 09:27
chat button to use the footer based one.
a view is presented modally on the user profile view
breaking screen presentations
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 73.79310% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 74.31%. Comparing base (1166400) to head (e432f80).

❗ Current head e432f80 differs from pull request most recent head e6afcb5. Consider uploading reports for the commit e6afcb5 to get more accurate results

Files Patch % Lines
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 0.00% 17 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 9.09% 10 Missing ⚠️
...ilsScreen/RoomMemberDetailsScreenCoordinator.swift 0.00% 2 Missing ⚠️
...erDetailsScreen/View/RoomMemberDetailsScreen.swift 94.87% 2 Missing ⚠️
...erProfileScreen/UserProfileScreenCoordinator.swift 0.00% 2 Missing ⚠️
...UserProfileScreen/UserProfileScreenViewModel.swift 75.00% 2 Missing ⚠️
...ens/UserProfileScreen/View/UserProfileScreen.swift 95.12% 2 Missing ⚠️
...tailsScreen/RoomMemberDetailsScreenViewModel.swift 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2822      +/-   ##
===========================================
+ Coverage    74.23%   74.31%   +0.08%     
===========================================
  Files          582      582              
  Lines        41162    41382     +220     
===========================================
+ Hits         30555    30753     +198     
- Misses       10607    10629      +22     
Flag Coverage Δ
unittests 62.12% <73.79%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 force-pushed the mauroromito/user_profile_changes branch from e432f80 to e6afcb5 Compare May 9, 2024 15:15
Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 enabled auto-merge (squash) May 9, 2024 15:15
@Velin92 Velin92 merged commit 783eab2 into develop May 9, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/user_profile_changes branch May 9, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] UX cleanup: user profile screen
2 participants