-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX Update for user profile screen and room member details #2822
Conversation
9159497
to
eebaa5d
Compare
Generated by 🚫 Danger Swift against e6afcb5 |
ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinator.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomMemberDetailsScreen/RoomMemberDetailsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/UserProfileScreen/UserProfileScreenViewModel.swift
Outdated
Show resolved
Hide resolved
PreviewTests/__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-15-pseudo.Other-User.png
Outdated
Show resolved
Hide resolved
chat button to use the footer based one.
a view is presented modally on the user profile view
breaking screen presentations
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2822 +/- ##
===========================================
+ Coverage 74.23% 74.31% +0.08%
===========================================
Files 582 582
Lines 41162 41382 +220
===========================================
+ Hits 30555 30753 +198
- Misses 10607 10629 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e432f80
to
e6afcb5
Compare
|
This PR also changed the behaviour of the form button style all across the app, and introduced a way to start calls directly when checking a user profile (if a DM already exists)
fixes #2816