Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating multiple clients if the NSE is invoked more than once … #2944

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

stefanceriu
Copy link
Contributor

@stefanceriu stefanceriu commented Jun 19, 2024

…on the same process

This came out of a discussion with @bnjbvr from which I quote:

it's of uttermost importance that there's at most one Client per process ... We put all our context in there, viz. locks, viz. OIDC data, so there needs to be at most one per different account

@stefanceriu stefanceriu requested a review from a team as a code owner June 19, 2024 14:04
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team June 19, 2024 14:04
Copy link

github-actions bot commented Jun 19, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 29b9e36

@stefanceriu stefanceriu force-pushed the stefan/singleClientPerProcess branch from 0b3a3ee to 71a65c8 Compare June 19, 2024 14:23
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 78.34%. Comparing base (b94111a) to head (985b51a).
Report is 1 commits behind head on develop.

Current head 985b51a differs from pull request most recent head 29b9e36

Please upload reports for the commit 29b9e36 to get more accurate results.

Files Patch % Lines
NSE/Sources/NotificationServiceExtension.swift 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2944      +/-   ##
===========================================
+ Coverage    78.31%   78.34%   +0.02%     
===========================================
  Files          691      691              
  Lines        54028    54146     +118     
===========================================
+ Hits         42313    42420     +107     
- Misses       11715    11726      +11     
Flag Coverage Δ
unittests 68.99% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu force-pushed the stefan/singleClientPerProcess branch from 985b51a to 40f16d2 Compare June 19, 2024 16:23
@stefanceriu stefanceriu force-pushed the stefan/singleClientPerProcess branch from 40f16d2 to 29b9e36 Compare June 19, 2024 16:43
Copy link

sonarcloud bot commented Jun 19, 2024

@stefanceriu stefanceriu merged commit 23b0cde into develop Jun 19, 2024
5 checks passed
@stefanceriu stefanceriu deleted the stefan/singleClientPerProcess branch June 19, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants