-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add right panel with Room information #365
Merged
Merged
Changes from 1 commit
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
c7ba472
Add view and vm for RoomInformation
MidhunSureshR c7fd0fa
Allow details to be child of room
MidhunSureshR 986271d
Add code to toggle RoomInformation panel
MidhunSureshR e39572b
Create RoomInformationView on toggle
MidhunSureshR 96959a3
Put name of property in emitChange
MidhunSureshR 439910f
Handle case when path.get() may be null
MidhunSureshR 98d8d44
Allow details to be child of rooms
MidhunSureshR 7e38c3e
Remove right panel on grid update if needed
MidhunSureshR ddaa9b4
Dispose vm preemptively
MidhunSureshR c3333f5
Extract method
MidhunSureshR 9a605cc
Remove unnecessary check
MidhunSureshR 0d11f85
Add CSS to display sidebar to the right
MidhunSureshR 191eb09
Fallback to canonical alias if no names found
MidhunSureshR 0ea2843
Add background for sidebar
MidhunSureshR 6f1b77b
Add room avatar to RoomInfoView
MidhunSureshR aece82d
Make room avatar larger in RoomInfoView
MidhunSureshR d502a7f
Make display name bold
MidhunSureshR a23e2c3
Better styling
MidhunSureshR 0a4f8af
Create method to add sidebar element
MidhunSureshR 653fcbb
Add method to create avatar section
MidhunSureshR ee29d7f
Bring in icon assets
MidhunSureshR f42553f
Add avatar size for design
MidhunSureshR c96abc8
Add css to place items appropriately
MidhunSureshR b0535b5
Add styling for RoomInfoView
MidhunSureshR 91f083a
Add close button to RoomInfoView
MidhunSureshR c65e26e
Position the close button to right end
MidhunSureshR 20a250d
Style close button
MidhunSureshR 37367cd
Make close button close the view
MidhunSureshR ecd5505
Bring in info icon
MidhunSureshR 4edc58e
Add button in Room header to open details
MidhunSureshR b5480b0
Style open button
MidhunSureshR 9ac415f
Show panel when first visit contains /details
MidhunSureshR eab6ca3
Make side-bar responsive
MidhunSureshR d782c9e
Justify content to flex-end instead
MidhunSureshR 2dcec63
Info icon should open/close view alternatively
MidhunSureshR 02d79b5
Prefer canonical alias over room_id if available
MidhunSureshR 426d077
Keep RoomInfoView open across room/grid changes
MidhunSureshR 1e96b58
Add link support to menu
MidhunSureshR 00dbd3d
Add menu entry to launch RoomInfoView
MidhunSureshR 040c744
Style links and buttons similarly in menu
MidhunSureshR f1fe17f
Make font-size equal to that of room-header
MidhunSureshR d3d65d8
Put sidebar rows into container
MidhunSureshR 3273682
Do not show room id instead of canonical alias
MidhunSureshR 8d254c9
Undo formatting/stylistic changes
MidhunSureshR a3271fb
Fix Menu: Use t instead of tag to get events
MidhunSureshR 98ef6f4
Use optionWithButton
MidhunSureshR 65bd744
Make menu-items uniform
MidhunSureshR 9074caf
Change Room Details --> Room details
MidhunSureshR 986f04a
Move Room details menu entry to top
MidhunSureshR a3587a8
Use internationalization for user facing strings
MidhunSureshR 04933ac
Add missing checks
MidhunSureshR 7f922af
Reduce duplication in code
MidhunSureshR a4bcb21
Move details handling to separate function
MidhunSureshR 37e052c
details do not need to be child of rooms
MidhunSureshR b2448e1
Calculate path when button is clicked
MidhunSureshR 5b74038
Check value of details everywhere
MidhunSureshR 0d63ce9
Change SideBarActive --> right-shown
MidhunSureshR 4c96294
Modify setters in MenuOption to support chaining
MidhunSureshR 4700009
Add new test for parseUrlPath
MidhunSureshR c6f3b1f
Do not use private props from room summary
MidhunSureshR 0406584
Remove unused getter
MidhunSureshR fcc2afb
Do not compute link in getter
MidhunSureshR eb870cf
Use url instead of link
MidhunSureshR 7fbcf89
Remove unncessary empty line
MidhunSureshR 332fbdd
Move variable to scope of conditional
MidhunSureshR 008f360
Remove link support from Menu
MidhunSureshR efd37d8
Update on changes to vm
MidhunSureshR f917730
Stick to naming convention for css/html classes
MidhunSureshR f3f1436
Rename room info to room details everywhere
MidhunSureshR 2c0176f
Remove unwanted width
MidhunSureshR 6086d15
Make value multiple of 4
MidhunSureshR 95512b5
Remove margin from top
MidhunSureshR fa67c5e
Refactor function
MidhunSureshR 4005d70
Increase height to make element more centered
MidhunSureshR dd9a19b
Make formatting consistent
MidhunSureshR 0c5d118
Add rule to warn on wrong formatting
MidhunSureshR b2f2d51
Make formatting consistent with the codebase
MidhunSureshR e2443a8
Undo spillover from earlier formatting havoc
MidhunSureshR e10b455
Rename method
MidhunSureshR 7b811aa
Remove space after brace in two places
MidhunSureshR 88a1e34
Unsubscribe on dispose
MidhunSureshR e50b503
Undo lint config change
MidhunSureshR 97e484b
Rename toggle --> open
MidhunSureshR 4f05d9a
Make navigation changes in one go
MidhunSureshR 1772fc0
Remove text(..)
MidhunSureshR 5e4db2f
Change font size
MidhunSureshR e161f61
Remove selector list
MidhunSureshR e2fd90b
Remove Segment import
MidhunSureshR a273b25
Remove css assumption
MidhunSureshR eb35f46
Make sure room does exist before creating vm
MidhunSureshR 09aba78
Merge branch 'master' into room-info
bwindels File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the
.right-shownnot needed then in here?